Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 꿀조합 저장 기능 추가 #67

Merged
merged 4 commits into from
May 30, 2024
Merged

feat: 꿀조합 저장 기능 추가 #67

merged 4 commits into from
May 30, 2024

Conversation

70825
Copy link
Member

@70825 70825 commented May 30, 2024 •
edited
Loading

Issue

✨ 구현한 기능

스크린샷 2024-05-30 오전 10 04 37
  • 유저가 꿀조합을 저장할 수 있는 기능을 추가합니다 (북마크 기능)

📢 논의하고 싶은 내용

  • 코드 자체는 좋아요 기능과 유사하게 만들었습니다.
  • 추가한 코드가 많아서 커밋별로 보고 리뷰 남기면 좋을 것 같아요

🎸 기타

⏰ 일정

  • 추정 시간 : 6
  • 걸린 시간 : 2

@70825 70825 self-assigned this May 30, 2024
@github-actions GitHub Actions
Copy link

Test Results

315 tests  +14   315 ✅ +14   19s ⏱️ -1s
194 suites + 5     0 💤 ± 0 
194 files   + 5     0 ❌ ± 0 

Results for commit a3eef62. ± Comparison against base commit 72c1c83.

Go-Jaecheol
Go-Jaecheol approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 수정할 부분은 안보이네요. 고생하셨습니다~ 👍

@70825 70825 merged commit 5546d43 into develop May 30, 2024
3 checks passed
@70825 70825 deleted the feat/issue-64 branch May 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

@wugawuga wugawuga Awaiting requested review from wugawuga

@hanueleee hanueleee Awaiting requested review from hanueleee

Assignees

@70825 70825

Labels
✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

꿀조합 저장 기능 추가
2 participants
@70825 @Go-Jaecheol